-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
fix isin method for series #52746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix isin method for series #52746
Conversation
Thanks for the PR @nvanommeren and @sophievdberg! The CI caught some errors which I think you can solve locally if you run pre-commit. Let us know if you need help. |
Thanks @noatamir, fixed some small problems. There are still quite some tests failing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be ok with updating the tests, adding a DataFrame here is weird. Are you ok with this @mroeschke ?
Yeah |
Thx! @nvanommeren Could you update the tests? |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.