Skip to content

fix isin method for series #52746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

nvanommeren
Copy link

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
@noatamir
Copy link
Member

Thanks for the PR @nvanommeren and @sophievdberg! The CI caught some errors which I think you can solve locally if you run pre-commit. Let us know if you need help.

@nvanommeren
Copy link
Author

Thanks @noatamir, fixed some small problems. There are still quite some tests failing in pandas/tests/computation/test_eval.py::TestEval::test_simple_cmp_ops - just to check: should we update these tests as well?

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be ok with updating the tests, adding a DataFrame here is weird. Are you ok with this @mroeschke ?

@mroeschke
Copy link
Member

Yeah Series.isin(df) should raise IMO

@phofl
Copy link
Member

phofl commented Apr 19, 2023

Thx! @nvanommeren Could you update the tests?

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label May 20, 2023
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprints Sprint Pull Requests Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Behaviour Series.isin with dataframe comparison is confusing [for discussion]
5 participants